Fixes and improvements to prepare for v0.8.0 release of FunLess#126
Merged
Conversation
Also fix module flag short version (from "n" to "m").
Also fix formatting in "admin user list" and "admin user create" command output.
giusdp
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds various missing features and fixes some long and short-lived bugs in the CLI, to align with the current version of the platform and improve the usability and functionality of the command line.
The tasks described below will be updated as they are completed, along with additional notes.
Specifically, this PR:
hostfrom the client config, and reads it from an existing config file (closes Use a config to hold apihost #13)hostin every command, overwriting the existing config (closes --host flag to specify custom host #14)fn,modandusersubcommands, where the API is actually usedfn,modanduser), allowing communication with the new version of FunLessfl config set <property> <value>/fl config get <property>)5.19.0-35-generic).SECRET_KEY_BASEvariable in the config fileSECRET_KEY_BASEduring deployment, both on Docker and k8s, allowing the proper initializationand insert them in the config filecfgcommand